Added a caution note about services that must maintain the "class" parameter #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 29, 2017
service_container/3.3-di-changes.rst
Outdated
|
|
||
| Services associated with global PHP classes (i.e. not using PHP namespaces) | ||
| must maintain the ``class`` parameter. For example, when using the old Twig | ||
| classes (e.g. ``Twig_Extensions_Extension_Intl`` instead of ``Twig\Extensions\IntlExtension``) |
There was a problem hiding this comment.
missing comma at the end of the line
xabbuh
reviewed
May 29, 2017
service_container/3.3-di-changes.rst
Outdated
| Services associated with global PHP classes (i.e. not using PHP namespaces) | ||
| must maintain the ``class`` parameter. For example, when using the old Twig | ||
| classes (e.g. ``Twig_Extensions_Extension_Intl`` instead of ``Twig\Extensions\IntlExtension``) | ||
| you can't redefine the service as `Twig_Extensions_Extension_Intl: ~` and |
HeahDude
approved these changes
Jul 25, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Aug 1, 2017
…e "class" parameter (javiereguiluz, HeahDude) This PR was merged into the 3.3 branch. Discussion ---------- Added a caution note about services that must maintain the "class" parameter This fixes #7935. Commits ------- 4219a5e minor fix b857caf Added a caution note about services that must maintain the "class" parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7935.